[webkit-reviews] review requested: [Bug 35207] all xhtml documents fail to render when XHTMLMP enabled : [Attachment 49145] fix patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 21 00:01:23 PST 2010


Charles Wei <charles.wei at torchmobile.com.cn> has asked	for review:
Bug 35207: all xhtml documents fail to render when XHTMLMP enabled
https://bugs.webkit.org/show_bug.cgi?id=35207

Attachment 49145: fix patch
https://bugs.webkit.org/attachment.cgi?id=49145&action=review

------- Additional Comments from Charles Wei <charles.wei at torchmobile.com.cn>
When the XHTMLMP is enabled, the author added one member function to class
Document to decide if the document is of XHTMLMP type, and they later on in the
tokenizer, it validates if the right Doctype is declared for xhtml-mp document.


The right MIME type for XHTMLMP is "application/vnd.wap.xhtml+xml",  while in
the new member function isXHTMLMPDocument() of Document,  it returns true for
both "application/vnd.wap.xhtml+xml" and "application/xhtml+xml".  In the
Tokenizer, it trys to validate that the XHTMLDocument contains the right DTD
declaration and public ID ("//WAPFORUM/DTD XHTML Mobile 1.0"),	sure it fails
for all the XHTML (non-MP) documents.

Ths fix for this bug is only documents with MIME type
"application/wap.vnd.xhtml+xml" will be treated as XHTMLMP documents;	MIME
type "application/xhtml+xml" is for XHTML documents.


More information about the webkit-reviews mailing list