[webkit-reviews] review denied: [Bug 25648] When the video controls are updated the whole video is redisplayed (RenderSlider repaint). : [Attachment 49112] prevent excessive relayouts

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 20 10:47:42 PST 2010


mitz at webkit.org has denied Hin-Chung Lam <hclam at google.com>'s request for
review:
Bug 25648: When the video controls are updated the whole video is  redisplayed
(RenderSlider repaint).
https://bugs.webkit.org/show_bug.cgi?id=25648

Attachment 49112: prevent excessive relayouts
https://bugs.webkit.org/attachment.cgi?id=49112&action=review

------- Additional Comments from mitz at webkit.org
I was curious about the case I mentioned in comment #32, so I applied this
patch and tested it. I discovered two things:
1) That case fails. It is easier to see if you enclose then <input> element in
a <div> with a border or a background. You should address this by refining the
check in objectIsRelayoutBoundary.
2) I was wrong about there not being a need to push layout state. It is needed,
but the offset is wrong. Instead of using size(), it should use IntSize(x(),
y()) as usual. Sorry about misleading you.


More information about the webkit-reviews mailing list