[webkit-reviews] review requested: [Bug 35191] [Gtk] use geoclue providers with don't provide update : [Attachment 49123] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 20 04:04:42 PST 2010


arno. <arno at renevier.net> has asked  for review:
Bug 35191: [Gtk] use geoclue providers with don't provide update
https://bugs.webkit.org/show_bug.cgi?id=35191

Attachment 49123: patch v1
https://bugs.webkit.org/attachment.cgi?id=49123&action=review

------- Additional Comments from arno. <arno at renevier.net>
path proposal:


after creating geocluePosition (with need_update to false), I call
geoclue_position_get_position_async. Asynchronous call is needed for two
things:
- not freezing the interface in case it takes a long time to have the position.

- not calling Geolocation::makeSuccessCallbacks before
Geolocation::startRequest returns (otherwise, makeSuccessCallbacks is called
with an empty m_oneShots).


More information about the webkit-reviews mailing list