[webkit-reviews] review granted: [Bug 35157] Remove auto_ptr usage in WebCore : [Attachment 49079] Proposed fix: change signatures, remove <memory> and auto_ptr reference

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 35157: Remove auto_ptr usage in WebCore
https://bugs.webkit.org/show_bug.cgi?id=35157

Attachment 49079: Proposed fix: change signatures, remove <memory> and auto_ptr
reference
https://bugs.webkit.org/attachment.cgi?id=49079&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
LGTM.

My only concern is if "Type" could end up getting used for a stack object.  We
only use PassOwnPtr to return or pass values, never as a stack object or an
instance variable.

05     template<> struct CrossThreadCopierBase<false, false, ResourceRequest> {

115	     typedef std::auto_ptr<CrossThreadResourceRequestData> Type;
 106	     typedef PassOwnPtr<CrossThreadResourceRequestData> Type;
116107	       static Type copy(const ResourceRequest&);
117108	   };
118109 
119110	   template<> struct CrossThreadCopierBase<false, false,
ResourceResponse> {
120	     typedef std::auto_ptr<CrossThreadResourceResponseData> Type;
 111	     typedef PassOwnPtr<CrossThreadResourceResponseData> Type;
121112	       static Type copy(const ResourceResponse&);
122113	   };