[webkit-reviews] review requested: [Bug 34219] [Gtk] Server message not shown on http authentication : [Attachment 49098] Patch to make server message visible in http authentication dialog

[bugzilla-daemon at webkit.org]

José Millán Soto <jmillan at igalia.com> has asked  for review:
Bug 34219: [Gtk] Server message not shown on http authentication
https://bugs.webkit.org/show_bug.cgi?id=34219

Attachment 49098: Patch to make server message visible in http authentication
dialog
https://bugs.webkit.org/attachment.cgi?id=49098&action=review

------- Additional Comments from José Millán Soto <jmillan at igalia.com>
This one creates only three rows if there's a realm.

(In reply to comment #12)
> - You are checking that the string is not NULL, but I guess you should also
> check that it's not ""?
Actually, I was checking that if it was "" (by checking realm[0]) and I was not
checking if it was NULL.

Now, I use strlen instead of doing realm[0] to check if it's an empty string
and it's also checked if it's NULL (soup_auth_get_realm should not return NULL,
but just in case)