[webkit-reviews] review granted: [Bug 35159] [Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender and add results for passing new tests : [Attachment 49082] proposed patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 35159: [Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender
and add results for passing new tests
https://bugs.webkit.org/show_bug.cgi?id=35159

Attachment 49082: proposed patch
https://bugs.webkit.org/attachment.cgi?id=49082&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
Looks good, but some comments


> +	   [Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender,
add results
> +	   for passing new tests and unskip the passing ones from the Skiplist.


It is called Skipped, not Skiplist


> +    QWebFrame* frame = m_page->mainFrame();
> +    if (frame)
> +	   frame->setTextSizeMultiplier(frame->textSizeMultiplier() *
ZOOM_STEP);
> +}

Why not do

if (QWebFrame* frame = m_page->mainFrame())
    frame->setTextSizeMultiplier(frame->textSizeMultiplier() * ZOOM_STEP);

?