[webkit-reviews] review canceled: [Bug 34850] [Qt] QScriptValue::toString() returns incorrect values : [Attachment 49063] Fix v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 19 07:58:55 PST 2010


Ariya Hidayat <ariya.hidayat at gmail.com> has canceled Jędrzej Nowacki
<jedrzej.nowacki at nokia.com>'s request for review:
Bug 34850: [Qt] QScriptValue::toString() returns incorrect values
https://bugs.webkit.org/show_bug.cgi?id=34850

Attachment 49063: Fix v3
https://bugs.webkit.org/attachment.cgi?id=49063&action=review

------- Additional Comments from Ariya Hidayat <ariya.hidayat at gmail.com>
Looks sane to me, except...

> +	   QByteArray buf;
> +	   buf.reserve(80);

..where does this value come from? I can't recall you can print a double value
into 80-char long string.

Maybe add some comment or use shorter buffer length for that?


More information about the webkit-reviews mailing list