[webkit-reviews] review requested: [Bug 18662] Extend keyboard navigation to allow directional navigation : [Attachment 49076] Add directional navigation to WebCore (LayoutTests - v1)

[bugzilla-daemon at webkit.org]

Antonio Gomes (tonikitoo) <tonikitoo at webkit.org> has asked  for review:
Bug 18662: Extend keyboard navigation to allow directional navigation
https://bugs.webkit.org/show_bug.cgi?id=18662

Attachment 49076: Add directional navigation to WebCore (LayoutTests - v1)
https://bugs.webkit.org/attachment.cgi?id=49076&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>
LayoutTests splitted on its own  file, to separate the code logic of the
feature to its tests, and also to help reviewers.

The following layout tests are included:

* snav-horizontal-superprecedence.html
* snav-iframe-no-focusable-content.html
* snav-iframe-no-scrollable-content.html
* snav-iframe-with-offscreen-focusable-element.html
* snav-table-traversal.html
* snav-tiny-table-traversal.html
* snav-unit-overflow-and-scroll-in-direction.html
* snav-vertical-superprecedence.html

, all them placed in LayoutTests/fast/events/spatial-navigation/

-> Each HTML has in its header explaination about what the patch is trying to
test.

-> spatial-navigation-utils.js is a helper that takes are of moving the focus
around between
elements, making sure it reaches the right target.

-> for now I am skipping the tests on all plaftorms (gtk, qt, mac, win) and
follow up bugs are to be filed individually to revert that. I've done it
already for qt and gtk.