[webkit-reviews] review denied: [Bug 35149] Web Inspector: Popover x position is negative. : [Attachment 49068] Calculation for x position of Popover is fixed.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 19 05:51:54 PST 2010


Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at google.com>'s request for review:
Bug 35149: Web Inspector: Popover x position is negative.
https://bugs.webkit.org/show_bug.cgi?id=35149

Attachment 49068: Calculation for x position of Popover is fixed.
https://bugs.webkit.org/attachment.cgi?id=49068&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Should be Math.max(10, anchorBox.x) - borderWidth; (10 should be a const with a
nice name such as "borderRadius")


More information about the webkit-reviews mailing list