[webkit-reviews] review denied: [Bug 33217] Web Inspector: there should be a way to "deactivate" or "skip" all breakpoints while debugging. : [Attachment 49064] [PATCH] Comments addressed, fixed glyphs, added Chromium backend support

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 33217: Web Inspector: there should be a way to "deactivate" or "skip" all
breakpoints while debugging.
https://bugs.webkit.org/show_bug.cgi?id=33217

Attachment 49064: [PATCH] Comments addressed, fixed glyphs, added Chromium
backend support
https://bugs.webkit.org/attachment.cgi?id=49064&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Two thoughts here:
1) It would be much cleaner (and would require no repaints) if you added some
opacity 0.5 style that would be applicable to line numbers with breakpoints.
2) Not related to this change, but worth fixing: _drawBreakpointImagesIfNeeded
and _drawProgramCounterImageIfNeeded should be static. We no longer have
iframes, so it is sufficient to create those only once.