[webkit-reviews] review requested: [Bug 34631] [Qt] Switching from Phonon to QtMultimedia Backend for Qt 4.7 : [Attachment 49059] Updated Patch - Simplified and Improved

[bugzilla-daemon at webkit.org]

Nick Young <nicholas.young at nokia.com> has asked  for review:
Bug 34631: [Qt] Switching from Phonon to QtMultimedia Backend for Qt 4.7
https://bugs.webkit.org/show_bug.cgi?id=34631

Attachment 49059: Updated Patch - Simplified and Improved
https://bugs.webkit.org/attachment.cgi?id=49059&action=review

------- Additional Comments from Nick Young <nicholas.young at nokia.com>
Ok. Here's the updated patch that I promised.
It removes the QPainterVideoSurface dependency, as well as dramatically
simplifying the task of painting video frames.

The method for painting is very similar to the previous patch, the difference
is it is deferred to a different class - QGraphicsVideoItem - which is in
QtMultimedia. We use this item even when we don't have a QGraphicsView. When we
do have a QGraphicsView, we can easily support Accelerated Compositing, I've
been chatting with Noam about this on IRC, so we should hopefully have another
patch not too far in the future.

Also in this patch is a bunch of bugfixes.
Including:
- More Robust Seeking
- Support for the recently added "supportsMuting()" API.
- Video Size changes are propagated to WebKit
- Different path for pulling the QNAM during load(), which actually works
_before_ our renderer is created (which is when load() is usually called).

We now have support for:

- Sublime Video HTML5 Player
> http://jilion.com/sublime/video
(Note that on OSX, QuickTime requires the entire movie to be buffered before it
will play. This seems to be specific to some HD movies, including the one used
on this page.) 

- Vimeo HTML5
(I've seen working on OSX. Am yet to test on other backends, but I believe this
should work.)

We are still working on support for youtube/html5. Cookies are being sent, but
our requests still result in 403 Forbidden.
Investigation is ongoing.

After realising that using the application pallete didn't work so well for the
controls on Mac, I went back to the hard coded colours approach.

Note that some of the issues previously mentioned were related to our QuickTime
backend on OSX.
You will need to pull a new version of qt-multimedia.

In fact, I recommend pulling qt-mulutimedia-team, which is our staging repo
that we're currently in the process of integrating in to Qt.