[webkit-reviews] review denied: [Bug 35087] New port: EFL; adding files to WebCore/*/efl : [Attachment 48996] Add EFL port files in WebCore/platform/graphics/efl

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Leandro Pereira
<leandro at profusion.mobi>'s request for review:
Bug 35087: New port: EFL; adding files to WebCore/*/efl
https://bugs.webkit.org/show_bug.cgi?id=35087

Attachment 48996: Add EFL port files in WebCore/platform/graphics/efl
https://bugs.webkit.org/attachment.cgi?id=48996&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
The vast majority of this patch is code copied from the Gtk equivalents, really
this should be shared code.  For that reason i suggest splitting this into two
distinct patches.

One which contains the EFL changes to core WebCore types (IntRect, etc), and
one that adds the EFL specific code to the Gtk platform code.

It's possible that some of the gtk code should be renamed from (for instance)
FontPlatformDataGtk to FontPlatformDataCairo, and MediaPlayerGtk to
MediaPlayerGStreamer, or at least the common cairo and gstreamer code be split
into gstreamer and cairo specific files, with separate efl and gtk files for
those pieces of functionality that aren't sharable.  The current copy-paste
model seems likely to reduce the ability of the Efl port to benefit from work
done on the Cairo and Gtk ports.  It may be worth discussing these file
renames, etc with Gustavo, Philippe, and Ken in #webkit-gtk