[webkit-reviews] review denied: [Bug 35084] New port: EFL; adding files to JavaScriptCore/wtf/efl : [Attachment 48993] Add EFL port files in JavaScriptCore/efl

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Leandro Pereira
<leandro at profusion.mobi>'s request for review:
Bug 35084: New port: EFL; adding files to JavaScriptCore/wtf/efl
https://bugs.webkit.org/show_bug.cgi?id=35084

Attachment 48993: Add EFL port files in JavaScriptCore/efl
https://bugs.webkit.org/attachment.cgi?id=48993&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
Welcome to WebKit :D

This patch is basically fine, but you shouldn't add
JavaScriptCore/wtf/efl/EOwnPtr.cpp as it's an (effectively) empty file.

You also need a changelog, to create it use the prepare-ChangeLog script, and
add appropriate description.

I'll r- this patch and wait for an updated patch with a changelog and the
superfluous file removed.