[webkit-reviews] review granted: [Bug 34675] check-webkit-style: Move ProcessorOptions, ArgumentPrinter, and ArgumentParser classes into a separate file : [Attachment 49041] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 18 18:59:58 PST 2010


Shinichiro Hamaji <hamaji at chromium.org> has granted Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 34675: check-webkit-style: Move ProcessorOptions, ArgumentPrinter, and
ArgumentParser classes into a separate file
https://bugs.webkit.org/show_bug.cgi?id=34675

Attachment 49041: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=49041&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Looks good. Hmm... it was a bit difficult to check code move change with
bugzilla. Eventually we may want to have better diff pretty printer.


More information about the webkit-reviews mailing list