[webkit-reviews] review granted: [Bug 35020] Move SVGResources to Renderers, starting with Masker : [Attachment 49045] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 18 15:04:46 PST 2010


Nikolas Zimmermann <zimmermann at kde.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 35020: Move SVGResources to Renderers, starting with Masker
https://bugs.webkit.org/show_bug.cgi?id=35020

Attachment 49045: Patch
https://bugs.webkit.org/attachment.cgi?id=49045&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
The commented code is gone, and I think it's safe to r+ now, as the
invalidateCanvasResources() ASSERT() is gone, leading to the world-breakage
when landing this patch the last time.
Calling deregisterFromResources() is cheap, it's only done on destruction of
renderers. This is not a common case ;-)


More information about the webkit-reviews mailing list