[webkit-reviews] review denied: [Bug 35091] style-queue should not complain about identifier names with underscores under WebKit/efl/ewk/ : [Attachment 49000] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 18 06:31:42 PST 2010


Shinichiro Hamaji <hamaji at chromium.org> has denied Leandro Pereira
<leandro at profusion.mobi>'s request for review:
Bug 35091: style-queue should not complain about identifier names with
underscores under WebKit/efl/ewk/
https://bugs.webkit.org/show_bug.cgi?id=35091

Attachment 49000: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=49000&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Looks good, but could you write a test case for this? The comment above
_PATH_RULES_SPECIFIER points where you should modify.

# Each string appearing in this nested list should have at least
# one associated unit test assertion.  These assertions are located,
# for example, in the test_path_rules_specifier() unit test method of
# checker_unittest.py.
_PATH_RULES_SPECIFIER = [

r- for this reason.


More information about the webkit-reviews mailing list