[webkit-reviews] review granted: [Bug 34859] Update Chromium port's usage of url_util::IsStandard : [Attachment 48674] Path with style fixed.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 18 00:04:57 PST 2010


Adam Barth <abarth at webkit.org> has granted Brett Wilson (Google)
<brettw at chromium.org>'s request for review:
Bug 34859: Update Chromium port's usage of url_util::IsStandard
https://bugs.webkit.org/show_bug.cgi?id=34859

Attachment 48674: Path with style fixed.
https://bugs.webkit.org/attachment.cgi?id=48674&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Looks reasonable.  I didn't understand the relation between

- m_url.utf8String().length(),

and the rest of the patch.  Also, please fix the indentation in
V8LocationCustom to be four spaces.  (Not sure why the style elf missed that.)


More information about the webkit-reviews mailing list