[webkit-reviews] review requested: [Bug 35064] windowless plugins don't get button press events for right mouse button : [Attachment 48958] don't drop right mouse press events if the frame doesn't handle them
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 17 18:45:20 PST 2010
Brian Tarricone <bjt23 at cornell.edu> has asked for review:
Bug 35064: windowless plugins don't get button press events for right mouse
button
https://bugs.webkit.org/show_bug.cgi?id=35064
Attachment 48958: don't drop right mouse press events if the frame doesn't
handle them
https://bugs.webkit.org/attachment.cgi?id=48958&action=review
------- Additional Comments from Brian Tarricone <bjt23 at cornell.edu>
Ok, I think I figured it out. The gtk WebKitWebView button-press-event handler
was dropping the right press if EventHandler::sendContextMenuEvent() chose not
to handle the event (which is the case when you right-click over a windowless
plugin). I *think* the correct behavior is that the button-press-event handler
should handle the event as usual if
webkit_web_view_forward_context_menu_event() returns FALSE. This patch does
just that.
More information about the webkit-reviews
mailing list