[webkit-reviews] review denied: [Bug 34705] [BREWMP] Add a function to create a BREW instance without local variable declarations. : [Attachment 48338] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 17 15:54:47 PST 2010


Eric Seidel <eric at webkit.org> has denied Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 34705: [BREWMP] Add a function to create a BREW instance without local
variable declarations.
https://bugs.webkit.org/show_bug.cgi?id=34705

Attachment 48338: Patch
https://bugs.webkit.org/attachment.cgi?id=48338&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Why would this be part of WTF?	This seems like port-specific goop.

We don't need to have PassOwnPtrBrew to approve this, but eventually it would
be nice to have such a class to make leaking memory returned from this function
impossible.


More information about the webkit-reviews mailing list