[webkit-reviews] review denied: [Bug 33570] [BREWMP] Map FastMalloc to BREW memory allocator : [Attachment 48198] FastMalloc

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 17 15:17:51 PST 2010


Eric Seidel <eric at webkit.org> has denied Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 33570: [BREWMP] Map FastMalloc to BREW memory allocator
https://bugs.webkit.org/show_bug.cgi?id=33570

Attachment 48198: FastMalloc
https://bugs.webkit.org/attachment.cgi?id=48198&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Please add a comment before the #defines explaining why they're the right thing
to do. Similar perhaps to how you explained things in teh bug.	That although
BREW defines "malloc()" you can't use it because the loader does not initialize
the base address properly.  (Is this a bug in brew?  If so, is there a bug url
tracking it?  If so, you should include it.)

Once we have enough justification in the code, we can land this kind of hack. 
As is I think this code would just confuse future folks trying to read it.


More information about the webkit-reviews mailing list