[webkit-reviews] review granted: [Bug 34975] [Qt] Correct build problems while building QtWebKit inside Qt. : [Attachment 48869] Patch v2

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.1.gombos at nokia.com> has granted Jocelyn Turcotte
<jocelyn.turcotte at nokia.com>'s request for review:
Bug 34975: [Qt] Correct build problems while building QtWebKit inside Qt.
https://bugs.webkit.org/show_bug.cgi?id=34975

Attachment 48869: Patch v2
https://bugs.webkit.org/attachment.cgi?id=48869&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
Looks good to me, r+.

It would be better to assign value to VERSION at same location. Perhaps you can
make that change during landing just by moving some code around.

Something like this:

CONFIG(QTDIR_build) {
    include($$QT_SOURCE_TREE/src/qbase.pri)
    # Qt will set the version for us when building in Qt's tree
    VERSION=$${QT_MAJOR_VERSION}.$${QT_MINOR_VERSION}.$${QT_PATCH_VERSION}
} else: VERSION = 4.7.0