[webkit-reviews] review requested: [Bug 35009] [V8] Add context type variable to global object and merge object wrapping paths : [Attachment 48938] faster patch

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 35009: [V8] Add context type variable to global object and merge object
wrapping paths
https://bugs.webkit.org/show_bug.cgi?id=35009

Attachment 48938: faster patch
https://bugs.webkit.org/attachment.cgi?id=48938&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
I'm having trouble determining whether this patch is a meaningful change in
dromaeo test performance, but it's a big (5% or so) improvement on the dom
benchmark test.

It's a bit hackish though. The idea is to tell what type of context were in by
the internal field count on the wrapper context object. This works as long as
DOMWindow objects and WorkerContext objects have different field counts, which
given the huge disparity will likely remain true indefinitely.	I included an
ASSERT and a comment to this effect as a precaution though.

I recognize this may be too much of a hack, but I figured I'd throw it out and
see what people think.