[webkit-reviews] review granted: [Bug 35045] Add a way for WebView and its dependencies to be selectively included in WebKitStatistics leak tracking : [Attachment 48914] Proposed Change

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 17 13:32:14 PST 2010


Adam Roben (aroben) <aroben at apple.com> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 35045: Add a way for WebView and its dependencies to be selectively
included in WebKitStatistics leak tracking
https://bugs.webkit.org/show_bug.cgi?id=35045

Attachment 48914: Proposed Change
https://bugs.webkit.org/attachment.cgi?id=48914&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> ++ (BOOL)isIncludedInWebKitStatistics;

I think it would be better to name this +shouldIncludeInWebKitStatistics. But
I'd only change this one method; everything else should keep using "is" (since
the other methods/members really mean "have I added myself to the relevant
WebKit statistic?").

Should it start with an underscore?

r=me


More information about the webkit-reviews mailing list