[webkit-reviews] review denied: [Bug 34633] WebSocket bufferedAmount should not be 0 when send after close. : [Attachment 48737] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 34633: WebSocket bufferedAmount should not be 0 when send after close.
https://bugs.webkit.org/show_bug.cgi?id=34633

Attachment 48737: Patch
https://bugs.webkit.org/attachment.cgi?id=48737&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+		 if (frameByte == 0x00 && !m_client)
		     m_client->didReceiveMessage(String::fromUTF8(msgStart, p -
msgStart));

The check is backwards (should be m_client, not !m_client). Did you run
regression tests with this change? If no test detects such a mistake, we should
try to make one that does.

Also, do we even need to continue parsing when m_client becomes null? It seems
that an early return would be a better solution.