[webkit-reviews] review denied: [Bug 26315] Empty element's ending tag is not shown by inspector : [Attachment 48893] [PATCH] Comments addressed

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 26315: Empty element's ending tag is not shown by inspector
https://bugs.webkit.org/show_bug.cgi?id=26315

Attachment 48893: [PATCH] Comments addressed
https://bugs.webkit.org/attachment.cgi?id=48893&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +WebInspector.ElementsTreeElement.ForbiddenClosingTagElements = {
> +    "area": 1,
> +    "base": 1,

This should be an array that you call .keySet() on to get a object. That will
let you have multiple tags on a line to take less vertical space.

>	   this.treeOutline.updateSelection();
> +	   this.updateTitle();

You should call updateTitle before updateSelection. Since updateTitle might
change the height of the row and updateSelection needs to ccount for the row
height.

>	   this.treeOutline.updateSelection();
> +	   this.updateTitle();

Ditto, you should call updateTitle before updateSelection.