[webkit-reviews] review granted: [Bug 34382] When a live iframe element is moved between pages, it still depends on the old page. : [Attachment 48684] Updated patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Dmitry Titov
<dimich at chromium.org>'s request for review:
Bug 34382: When a live iframe element is moved between pages, it still depends
on the old page.
https://bugs.webkit.org/show_bug.cgi?id=34382

Attachment 48684: Updated patch
https://bugs.webkit.org/attachment.cgi?id=48684&action=review

------- Additional Comments from David Levin <levin at chromium.org>
r=me (as long as there are ok's from the other two folks involved for qt and
chromium specific changes).

Two minor nits below.


> diff --git a/WebCore/html/HTMLFrameOwnerElement.h
b/WebCore/html/HTMLFrameOwnerElement.h
> +    virtual void setName() {}

Would be nice to add a space inside of the {}.


> diff --git a/WebCore/loader/EmptyClients.h b/WebCore/loader/EmptyClients.h
> +    virtual void didTransferChildFrameToNewDocument() { return; }

"return;" isn't needed here.  In other words, s/{ return; }/{ }/