[webkit-reviews] review granted: [Bug 34932] check-webkit-style: Code clean-up prior to dividing ProcessorOptions into two classes : [Attachment 48830] Proposed patch 2

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has granted Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 34932: check-webkit-style: Code clean-up prior to dividing ProcessorOptions
into two classes
https://bugs.webkit.org/show_bug.cgi?id=34932

Attachment 48830: Proposed patch 2
https://bugs.webkit.org/attachment.cgi?id=48830&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Looks good. Thanks a lot for isolating this change!

> +# Each string appearing in this nested list should have at least
> +# one associated unit test assertion.

I'd say where we should add the test. Maybe "See test_path_rules_specifier in
checker_unittest.py" or something like this.