[webkit-reviews] review granted: [Bug 35009] [V8] Add context type variable to global object and merge object wrapping paths : [Attachment 48848] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 16 18:02:30 PST 2010


Adam Barth <abarth at webkit.org> has granted Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 35009: [V8] Add context type variable to global object and merge object
wrapping paths
https://bugs.webkit.org/show_bug.cgi?id=35009

Attachment 48848: patch
https://bugs.webkit.org/attachment.cgi?id=48848&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Ok.  I'm not super happy about:

+
V8DOMWindow::toNative(v8::Handle<v8::Object>::Cast(global->GetPrototype()))->fr
ame()

That seems like too low-level a manipulation for that program point.  Don't we
have a helper function somewhere that does that kind of thing?


More information about the webkit-reviews mailing list