[webkit-reviews] review denied: [Bug 34624] window.close() should only work if opened via script. : [Attachment 48838] Patch3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 16 17:51:34 PST 2010


Adam Barth <abarth at webkit.org> has denied Kavita Kanetkar
<kkanetkar at chromium.org>'s request for review:
Bug 34624: window.close() should only work if opened via script.
https://bugs.webkit.org/show_bug.cgi?id=34624

Attachment 48838: Patch3
https://bugs.webkit.org/attachment.cgi?id=48838&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I'm not sure that's the right way to log a message to the error console.  You
might want to look at how the canAccess checks log to the error console.  Also,
you might consider giving the developer more context about what's going one. 
For example "Refused to close window because the window was not opened by a
script."


More information about the webkit-reviews mailing list