[webkit-reviews] review granted: [Bug 35000] [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base classes : [Attachment 48837] [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base classes.

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted James Hawkins
<jhawkins at google.com>'s request for review:
Bug 35000: [Chromium] Remove calls to releaseRef when passing PassRefPtrs to
base classes
https://bugs.webkit.org/show_bug.cgi?id=35000

Attachment 48837: [Chromium] Remove calls to releaseRef when passing
PassRefPtrs to base classes.
https://bugs.webkit.org/attachment.cgi?id=48837&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebKit/chromium/ChangeLog
...
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   [Chromium] Remove calls to releaseRef when passing PassRefPtrs to
base
> +	   classes.  releaseRef releases the original pointer without
decreasing
> +	   the reference count, and the base class constructor increases the
> +	   reference count, leading to a leak.
> +
> +	   * src/WebDocument.cpp:

Oops, this ChangeLog needs a bug link.	Otherwise, LGTM