[webkit-reviews] review requested: [Bug 34932] check-webkit-style: Code clean-up prior to dividing ProcessorOptions into two classes : [Attachment 48829] Proposed patch

[bugzilla-daemon at webkit.org]

Chris Jerdonek <cjerdonek at webkit.org> has asked  for review:
Bug 34932: check-webkit-style: Code clean-up prior to dividing ProcessorOptions
into two classes
https://bugs.webkit.org/show_bug.cgi?id=34932

Attachment 48829: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=48829&action=review

------- Additional Comments from Chris Jerdonek <cjerdonek at webkit.org>
Note that I removed these patterns from _PATH_RULES_SPECIFIER:

-    # These are test file patterns.
-    (["_test.cpp",
-      "_unittest.cpp",
-      "_regtest.cpp"],
-     ("-readability/streams",	# Many unit tests use cout.
-      "-runtime/rtti")),

I found that no files in WebKit match them when looking for actual paths for
the _PATH_RULES_SPECIFIER unit tests.  I recall Adam saying in a
bugs.webkit.org comment that these were used previously by Google.  Thanks!