[webkit-reviews] review requested: [Bug 34850] [Qt] QScriptValue::toString() returns incorrect values : [Attachment 48807] Fix v2

[bugzilla-daemon at webkit.org]

Jędrzej Nowacki <jedrzej.nowacki at nokia.com> has asked  for review:
Bug 34850: [Qt] QScriptValue::toString() returns incorrect values
https://bugs.webkit.org/show_bug.cgi?id=34850

Attachment 48807: Fix v2
https://bugs.webkit.org/attachment.cgi?id=48807&action=review

------- Additional Comments from Jędrzej Nowacki <jedrzej.nowacki at nokia.com>
(In reply to comment #2)
> (From update of attachment 48635 [details])
> 
> > +	     // FIXME this should be easier. The QString API had to be
developed, it should contain
> > +	     // a converting function, a bit more flexible then the number().
The ideal fix is to create
> > +	     // a new function in JSC C API which could cover the
functionality.
> 
> I suggest to pursue that route by adding the functionality to the C API.
> 
> The old set of unit tests that this patch removes also include a test of
> converting a QScriptValue containing a non-latin string back to a QString.
The
> new test set does removes that from the input values. Is that intentional?
> 
> I'm okay with having the workaround in QScriptConverter for now, but I'm
> concerned about the removal of the utf8 test.
Agree, I renamed old test instead of replacing it.