[webkit-reviews] review granted: [Bug 32724] [Qt] It should be possible to disable inspector : [Attachment 48795] Patch against latest SVN, fix new compilation failures

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Ismail "cartman" Donmez
<ismail at namtrac.org>'s request for review:
Bug 32724: [Qt] It should be possible to disable inspector
https://bugs.webkit.org/show_bug.cgi?id=32724

Attachment 48795: Patch against latest SVN, fix new compilation failures
https://bugs.webkit.org/attachment.cgi?id=48795&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
>  
>  static InspectorTimelineAgent* inspectorTimelineAgent(RenderObject*
renderer)
>  {
> +#if !ENABLE(INSPECTOR)
> +    return 0;
> +#else
>      Frame* frame = renderer->document()->frame();
>      if (!frame)
>	   return 0;
> @@ -1026,6 +1029,7 @@ static InspectorTimelineAgent*
inspectorTimelineAgent(RenderObject* renderer)
>      if (!page)
>	   return 0;
>      return page->inspectorTimelineAgent();
> +#endif
>  }


You should just surround this entire method with if ENABLE(INSPECTOR). Please
fix this before landing.

>  
>  // Up-call from compositing layer drawing callback.
> diff --git a/WebKit/qt/Api/qwebpage.cpp b/WebKit/qt/Api/qwebpage.cpp
> index 185a2ee..256d6c4 100644
> --- a/WebKit/qt/Api/qwebpage.cpp
> +++ b/WebKit/qt/Api/qwebpage.cpp
> @@ -163,27 +163,42 @@ QString QWEBKIT_EXPORT qt_webpage_groupName(QWebPage*
page)
>  
>  void QWEBKIT_EXPORT qt_drt_webinspector_executeScript(QWebPage* page, long
callId, const QString& script)
>  {

Nit: In case these are only used from within DRT, should you hide these methods
as well and use guards in layout test controller instead?