[webkit-reviews] review granted: [Bug 34966] Autoplaying video with poster doesn't reliably show up : [Attachment 48788] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 34966: Autoplaying video with poster doesn't reliably show up
https://bugs.webkit.org/show_bug.cgi?id=34966

Attachment 48788: Patch
https://bugs.webkit.org/attachment.cgi?id=48788&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>

 22 <video width="480" height="270" type="video/mp4" src="content/test.mp4"
poster="content/abe.png" autoplay>

+ <video> doesn't have a 'type' attribute, only <source> does. You should just
remove it.


+ Not all ports support MPEG-4, but there are alternate encodings of all of
most test movies so instead of hardcoding the src directly in the markup you
should include "media-file.js" and set the src in doSetup with 

  video.src = findMediaFile("video", "content/test");


+ We have hardware compositing on Windows, won't it break unless it implements
platformLayer()?

r=me with these changes