[webkit-reviews] review granted: [Bug 34965] With hardware acceleration turned off, video frames never display if poster image is specified : [Attachment 48786] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 15 20:27:58 PST 2010


Eric Carlson <eric.carlson at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 34965: With hardware acceleration turned off, video frames never display if
poster image is specified
https://bugs.webkit.org/show_bug.cgi?id=34965

Attachment 48786: Patch
https://bugs.webkit.org/attachment.cgi?id=48786&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
Because updatePosterImage is now called for every video frame, it might make
sense to change HTMLVideoElement::updatePosterImage so hasAvailableVideoFrame()
is called before poster().isEmpty() as I assume it is cheaper as the later
requires an allocation. 

r=me either way


More information about the webkit-reviews mailing list