[webkit-reviews] review denied: [Bug 33630] SVG not rendered as background-image from data URI : [Attachment 48441] Patch v6

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 15 17:34:47 PST 2010


Nikolas Zimmermann <zimmermann at kde.org> has denied Yael
<yael.aharon at nokia.com>'s request for review:
Bug 33630: SVG not rendered as background-image from data URI
https://bugs.webkit.org/show_bug.cgi?id=33630

Attachment 48441: Patch v6
https://bugs.webkit.org/attachment.cgi?id=48441&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Hi Yael,

the patch looks almost perfect. Though you forgot to add the -expected.txt
file.
I highly suggest to remove the text from the test, so you can safely add the
-expected.txt file in svg/css/ directly.
There should be no need to skip other platforms than mac & qt.

Can you have a look?


More information about the webkit-reviews mailing list