[webkit-reviews] review denied: [Bug 34881] [GStreamer] Notify about size changes : [Attachment 48640] 0001-Notify-about-size-changes-in-the-WebKit-GStreamer-so.patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Sebastian Dröge
<slomo at circular-chaos.org>'s request for review:
Bug 34881: [GStreamer] Notify about size changes
https://bugs.webkit.org/show_bug.cgi?id=34881

Attachment 48640:
0001-Notify-about-size-changes-in-the-WebKit-GStreamer-so.patch
https://bugs.webkit.org/attachment.cgi?id=48640&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
 2  *  Copyright (C) 2009,2010 Sebastian Dröge
<sebastian.droege at collabora.co.uk>

Add a space here (between the , and 2010 =))

 249	 // than 20% of data. This allows us to need some time
 250	 // to unpause the SoupMessage and not starve the pipeline
 251	 // until it is finally unpaused.

I don't get this comment. What does 'allows us to need some time' mean? I
assume you want to say that you are raising the ammount of data that is
buffered before the message is paused, so that you lower the risk of delays in
unpausing starving the pipeline, right?

r- for the confusing comment, I believe the rest of the patch looks good, but
we need to get this comment straight.