[webkit-reviews] review denied: [Bug 32128] [Chromium] webcore_bindings target builds too slowly : [Attachment 48751] derivedsources hack

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied  review:
Bug 32128: [Chromium] webcore_bindings target builds too slowly
https://bugs.webkit.org/show_bug.cgi?id=32128

Attachment 48751: derivedsources hack
https://bugs.webkit.org/attachment.cgi?id=48751&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
> diff --git a/WebCore/WebCore.gyp/WebCore.gyp
b/WebCore/WebCore.gyp/WebCore.gyp
> index e40da56..5734c12 100644
> --- a/WebCore/WebCore.gyp/WebCore.gyp
> +++ b/WebCore/WebCore.gyp/WebCore.gyp
> @@ -579,6 +579,8 @@
>	   # This file includes all the .cpp files generated from the .idl
files
>	   # in webcore_files.
>	   '../bindings/v8/DerivedSourcesAllInOne.cpp',
> +	   '../bindings/v8/DerivedSourcesAllInTwo.cpp',
> +	   '../bindings/v8/DerivedSourcesAllInThree.cpp',
>  
>	   # Additional .cpp files from webcore_bindings_sources actions.
>	   '<(SHARED_INTERMEDIATE_DIR)/webkit/HTMLElementFactory.cpp',

Hm.  Seems like maybe we should have it do this for release but not debug? 
Maybe in release, AllInOne could then include the others and gyp would not
compile them?

> diff --git a/WebCore/bindings/v8/DerivedSourcesAllInThree.cpp
b/WebCore/bindings/v8/DerivedSourcesAllInThree.cpp
> new file mode 100644
> index 0000000..e7c10b7
> --- /dev/null
> +++ b/WebCore/bindings/v8/DerivedSourcesAllInThree.cpp
> @@ -0,0 +1,201 @@

Need copyright/license.

> diff --git a/WebCore/bindings/v8/DerivedSourcesAllInTwo.cpp
b/WebCore/bindings/v8/DerivedSourcesAllInTwo.cpp
> new file mode 100644
> index 0000000..00f012d
> --- /dev/null
> +++ b/WebCore/bindings/v8/DerivedSourcesAllInTwo.cpp
> @@ -0,0 +1,126 @@

Ditto on copyright/license.  + config.


Any reason you chose to split it into 3?  Maybe a bit more would be better?


Thanks a lot for doing this!  With these changes, I think we could actually
check this in as default!