[webkit-reviews] review denied: [Bug 34850] [Qt] QScriptValue::toString() returns incorrect values : [Attachment 48635] Fix v1

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Jędrzej Nowacki
<jedrzej.nowacki at nokia.com>'s request for review:
Bug 34850: [Qt] QScriptValue::toString() returns incorrect values
https://bugs.webkit.org/show_bug.cgi?id=34850

Attachment 48635: Fix v1
https://bugs.webkit.org/attachment.cgi?id=48635&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>

> +	   // FIXME this should be easier. The QString API had to be developed,
it should contain
> +	   // a converting function, a bit more flexible then the number(). The
ideal fix is to create
> +	   // a new function in JSC C API which could cover the functionality.

I suggest to pursue that route by adding the functionality to the C API.

The old set of unit tests that this patch removes also include a test of
converting a QScriptValue containing a non-latin string back to a QString. The
new test set does removes that from the input values. Is that intentional?

I'm okay with having the workaround in QScriptConverter for now, but I'm
concerned about the removal of the utf8 test.