[webkit-reviews] review granted: [Bug 34847] [Qt] QScriptValue::toIntXX returns incorrect values : [Attachment 48571] Fix v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 15 03:47:27 PST 2010
Simon Hausmann <hausmann at webkit.org> has granted Jędrzej Nowacki
<jedrzej.nowacki at nokia.com>'s request for review:
Bug 34847: [Qt] QScriptValue::toIntXX returns incorrect values
https://bugs.webkit.org/show_bug.cgi?id=34847
Attachment 48571: Fix v1
https://bugs.webkit.org/attachment.cgi?id=48571&action=review
------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
> + return (result > 0) ? qFloor(result) : -1 * qFloor(-result);
I'd leave out the first pair of parentheses. The rest looks good to me.
More information about the webkit-reviews
mailing list