[webkit-reviews] review canceled: [Bug 20695] Inspector should display Array lengths in the property lists : [Attachment 48731] Add lengths to the description of Arrays, NodeLists, and HTMLCollections in the Inspector property lists (and not in the console as well)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 14 14:07:48 PST 2010


Timothy Hatcher <timothy at hatcher.name> has canceled Jessie Berlin
<jberlin at webkit.org>'s request for review:
Bug 20695: Inspector should display Array lengths in the property lists
https://bugs.webkit.org/show_bug.cgi?id=20695

Attachment 48731: Add lengths to the description of Arrays, NodeLists, and
HTMLCollections in the Inspector property lists (and not in the console as
well)
https://bugs.webkit.org/attachment.cgi?id=48731&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog

> +    if (result.type == "array")

Use ===.


> +	   if (this.property.value.propertyLength !== undefined)

Should be: typeof this.property.value.propertyLength !== "undefined"


More information about the webkit-reviews mailing list