[webkit-reviews] review requested: [Bug 34251] Web Inspector: [REGRESSION] Search doesn't continue highlighting elements on hitting 'Enter' key : [Attachment 48733] [PATCH] Now setting highlight in updateTitle.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 34251: Web Inspector: [REGRESSION] Search doesn't continue highlighting
elements on hitting 'Enter' key
https://bugs.webkit.org/show_bug.cgi?id=34251

Attachment 48733: [PATCH] Now setting highlight in updateTitle.
https://bugs.webkit.org/attachment.cgi?id=48733&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Changes to attributes are now handled properly. Changes to text nodes are
processed as remove/add though. As a result, newly created nodes are absent in
the searchResults array even if they contain matching text. But that is a
general issue that has been there for all the times. The right solution would
be to restart search from the current occurrence in case of changes to dom.