[webkit-reviews] review granted: [Bug 34790] [Gtk] wrong video aspect ratio : [Attachment 48633] updated patch (with test)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 14 08:31:46 PST 2010


Gustavo Noronha (kov) <gns at gnome.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 34790: [Gtk] wrong video aspect ratio
https://bugs.webkit.org/show_bug.cgi?id=34790

Attachment 48633: updated patch (with test)
https://bugs.webkit.org/attachment.cgi?id=48633&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
 47 gint greatestCommonDivisor(gint a, gint b);

You don't need to expose this function in the header. Just make it static, and
remove it from the .h (it's only used inside that file). Pay attention while
landing, you may need to use an svn checkout =(, I am not sure git svn will
handle the new binary file well. Thanks!


More information about the webkit-reviews mailing list