[webkit-reviews] review requested: [Bug 32405] [Qt] canvas clipping is buggy : [Attachment 48713] Fix GraphicsContext::roundToDevicePixels in Qt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 13 19:11:12 PST 2010


Noam Rosenthal <noam.rosenthal at nokia.com> has asked  for review:
Bug 32405: [Qt] canvas clipping is buggy
https://bugs.webkit.org/show_bug.cgi?id=32405

Attachment 48713: Fix GraphicsContext::roundToDevicePixels in Qt
https://bugs.webkit.org/attachment.cgi?id=48713&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
I found the source of the problem - our GraphicsContext::roundToDevicePixels
function is wrong, as it doesn't make the right calculation in the case of
rotating images.
The attached fix makes that function completely equivalent to the CG
implementation, and rotating canvas images now look fine!


More information about the webkit-reviews mailing list