[webkit-reviews] review requested: [Bug 32290] [GTK] can't input korean into lower all input box except adress input box in webkit gtk launcher : [Attachment 48709] Patch for this issue (rev4)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 13 12:43:31 PST 2010


Martin Robinson <mrobinson at webkit.org> has asked  for review:
Bug 32290: [GTK] can't input korean into lower all input box except adress
input box in webkit gtk launcher
https://bugs.webkit.org/show_bug.cgi?id=32290

Attachment 48709: Patch for this issue (rev4)
https://bugs.webkit.org/attachment.cgi?id=48709&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
I've attached an updated patch with the following changes:
    - Fixed the case where a page calls preventDefault() on some keypress
events.
    - If a key release event is filtered and there is no pending composition,
block the event.
    - Added a few comments which describe the timeline of key events using the
'simple' context.
    - Add two more sets of unit tests.


More information about the webkit-reviews mailing list