[webkit-reviews] review canceled: [Bug 33478] Web Inspector shouldn't show a white color box for "-webkit-line-break: after-white-space" : [Attachment 48612] [PATCH] Smarter Regex

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has canceled Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 33478: Web Inspector shouldn't show a white color box for
"-webkit-line-break: after-white-space"
https://bugs.webkit.org/show_bug.cgi?id=33478

Attachment 48612: [PATCH] Smarter Regex
https://bugs.webkit.org/attachment.cgi?id=48612&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
I looked into cases of what could appear after a color in a valid value:

  - '$' for cases like "color: red;" where the value is "red"
  - ')' for cases like -webkit-gradiant's "from(red)", "to", and "color-stop"

These can be put into a positive lookahead at the end of the regex. Timothy
Hatcher mentioned whitespace and a comma, which I think are acceptable to add
in even though I can't think of cases for them yet.

This lookahead assertion can be used for all cases of colors, but is only
practically useful for the \b\w+\b word section, so the patch only uses it
there.