[webkit-reviews] review granted: [Bug 34921] Web Inspector: cache created row, span and text elements in TextView to improve scroller performance on debug build. : [Attachment 48704] [PATCH] Proposed change.

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 34921: Web Inspector: cache created row, span and text elements in TextView
to improve scroller performance on debug build.
https://bugs.webkit.org/show_bug.cgi?id=34921

Attachment 48704: [PATCH] Proposed change.
https://bugs.webkit.org/attachment.cgi?id=48704&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +	       var span = this._cachedSpans[this._cachedSpans.length - 1];
> +	       this._cachedSpans.length--;

I am surprised this works! You should just use the pop() function. This is done
in a few other places.


I also don't understand how this helps much, since you just cache te elements,
but the contents are replaces every time.

r+ if you change to use pop() before landing.