[webkit-reviews] review requested: [Bug 34915] Chromium: Need to be able to get the bounds of selection rectangle(s) : [Attachment 48691] This patch includes the changelog and stylistic changes as per style guide. It obsoletes the previously attached patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 12 19:20:37 PST 2010


Dmitriy Belenko <dbelenko at google.com> has asked  for review:
Bug 34915: Chromium: Need to be able to get the bounds of selection
rectangle(s)
https://bugs.webkit.org/show_bug.cgi?id=34915

Attachment 48691: This patch includes the changelog and stylistic changes as
per style guide. It obsoletes the previously attached patch.
https://bugs.webkit.org/attachment.cgi?id=48691&action=review

------- Additional Comments from Dmitriy Belenko <dbelenko at google.com>
Attaching a patch which includes the changelog and stylistic changes as per
style guide. It obsoletes the previously attached patch.

This patch adds a selectionBoundsRect method. This method returns false if
there is no selection. In case there is a selection, it sets the coordinates of
the rectangle passed into it by reference to the absolute bounds enclosing all
selections. I have verified that the boundary is identical to the one shown in
Apple's "expected" images.


More information about the webkit-reviews mailing list