[webkit-reviews] review requested: [Bug 34382] When a live iframe element is moved between pages, it still depends on the old page. : [Attachment 48680] Updated according to comments.

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has asked  for review:
Bug 34382: When a live iframe element is moved between pages, it still depends
on the old page.
https://bugs.webkit.org/show_bug.cgi?id=34382

Attachment 48680: Updated according to comments.
https://bugs.webkit.org/attachment.cgi?id=48680&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
I think I've got all comments in. Changes:

- [Qt] webPageChanged -> pageChanged and moved page setting code into
setPage(), as requested.
- [Qt] realized that main frame has QWebPage as QObject parent, while child
frames have their parent's QWebFrames as QObject parent - adjusted code for
that.
- [Chromium] - chatted with Darin and removed WebFrameClient notification until
the time we realize we need it.
- FrameLoaderClient::didTransferChildFrameToNewDocument lost "Document*"
parameter, since the new document can always be pulled from frame.
- test did not change.