[webkit-reviews] review requested: [Bug 34458] Refactor texImage2D and texSubImage2D taking Image to use common code : [Attachment 48670] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 12 15:23:10 PST 2010


Kenneth Russell <kbr at google.com> has asked  for review:
Bug 34458: Refactor texImage2D and texSubImage2D taking Image to use common
code
https://bugs.webkit.org/show_bug.cgi?id=34458

Attachment 48670: Patch
https://bugs.webkit.org/attachment.cgi?id=48670&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Please see ChangeLog for detailed description of patch.

Note to reviewers: I originally added multiple GraphicsContext3DUtil classes
(GraphicsContext3DUtilMac, GraphicsContext3DUtilSkia) but this added more
complexity than it was worth. I hope the few #ifdefs in GraphicsContext3DUtil
are acceptable.


More information about the webkit-reviews mailing list